Skip to content

Run UpsertClusterIntegrationTest test with both query engines. #11414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gortiz wants to merge 1 commit into from
Closed

Run UpsertClusterIntegrationTest test with both query engines. #11414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...java/org/apache/pinot/integration/tests/UpsertCompactionMinionClusterIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,10 @@ public void tearDown()
FileUtils.deleteDirectory(_tempDir);
}

@Test
public void testCompaction()
@Test(dataProvider = "useBothQueryEngines")
public void testCompaction(boolean useMultiStageQueryEngine)
throws Exception {
setUseMultiStageQueryEngine(useMultiStageQueryEngine);
waitForAllDocsLoaded(600_000L, 283);
assertEquals(getSalary(), 9747108);

Expand All @@ -199,9 +200,10 @@ public void testCompaction()
assertEquals(getSalary(), 9747108);
}

@Test
public void testCompactionDeletesSegments()
@Test(dataProvider = "useBothQueryEngines")
public void testCompactionDeletesSegments(boolean useMultiStageQueryEngine)
throws Exception {
setUseMultiStageQueryEngine(useMultiStageQueryEngine);
pushAvroIntoKafka(_avroFiles);
// Wait for all documents loaded
waitForAllDocsLoaded(600_000L, 566);
Expand Down
10 changes: 6 additions & 4 deletions ...on-tests/src/test/java/org/apache/pinot/integration/tests/UpsertTableIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,10 @@ protected void waitForAllDocsLoaded(long timeoutMs)
assertEquals(getCurrentCountStarResult(), getCountStarResult());
}

@Test
protected void testDeleteWithFullUpsert()
@Test(dataProvider = "useBothQueryEngines")
protected void testDeleteWithFullUpsert(boolean useMultiStageQueryEngine)
throws Exception {
setUseMultiStageQueryEngine(useMultiStageQueryEngine);
final UpsertConfig upsertConfig = new UpsertConfig(UpsertConfig.Mode.FULL);
upsertConfig.setDeleteRecordColumn(DELETE_COL);

Expand Down Expand Up @@ -265,9 +266,10 @@ protected void testDeleteWithFullUpsert(String kafkaTopicName, String tableName,
dropRealtimeTable(tableName);
}

@Test
public void testDeleteWithPartialUpsert()
@Test(dataProvider = "useBothQueryEngines")
public void testDeleteWithPartialUpsert(boolean useMultiStageQueryEngine)
throws Exception {
setUseMultiStageQueryEngine(useMultiStageQueryEngine);
final UpsertConfig upsertConfig = new UpsertConfig(UpsertConfig.Mode.PARTIAL);
upsertConfig.setDeleteRecordColumn(DELETE_COL);

Expand Down
5 changes: 3 additions & 2 deletions ...est/java/org/apache/pinot/integration/tests/UpsertTableSegmentPreloadIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,10 @@ private long getCountStarResultWithoutUpsert() {
return 600;
}

@Test
public void testSegmentAssignment()
@Test(dataProvider = "useBothQueryEngines")
public void testSegmentAssignment(boolean useMultiStageQueryEngine)
throws Exception {
setUseMultiStageQueryEngine(useMultiStageQueryEngine);
verifyIdealState(5);

// Run the real-time segment validation and check again
Expand Down
5 changes: 3 additions & 2 deletions ...test/java/org/apache/pinot/integration/tests/UpsertTableSegmentUploadIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,10 @@ private long getCountStarResultWithoutUpsert() {
return 600;
}

@Test
public void testSegmentAssignment()
@Test(dataProvider = "useBothQueryEngines")
public void testSegmentAssignment(boolean useMultiStageQueryEngine)
throws Exception {
setUseMultiStageQueryEngine(useMultiStageQueryEngine);
verifyIdealState();

// Run the real-time segment validation and check again
Expand Down