[multistage] Make join operator more resilient#11401
Merged
xiangfu0 merged 2 commits intoapache:masterfrom Aug 22, 2023
Merged
Conversation
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
Outdated
Show resolved
Hide resolved
17e4ab3 to
c2e4689
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11401 +/- ##
============================================
+ Coverage 62.89% 62.91% +0.02%
- Complexity 1079 1091 +12
============================================
Files 2301 2301
Lines 123699 123766 +67
Branches 18816 18833 +17
============================================
+ Hits 77803 77873 +70
+ Misses 40367 40355 -12
- Partials 5529 5538 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5c39b24 to
76d463c
Compare
76d463c to
71eedba
Compare
71eedba to
8733b7d
Compare
Jackie-Jiang
approved these changes
Aug 22, 2023
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
Outdated
Show resolved
Hide resolved
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/JoinNode.java
Outdated
Show resolved
Hide resolved
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/AbstractPlanNode.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Can you check if we read exception from the data block and EOS block? I feel they are just ignored
Contributor
Author
There was a problem hiding this comment.
they are ignored right now. Need to open up another thread to fix this.
8733b7d to
9847966
Compare
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/HashJoinOperator.java
Outdated
Show resolved
Hide resolved
54b4ea6 to
0c2d050
Compare
0c2d050 to
5c36a12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To protect the server from OOM, this PR introduces the limit for join operator to ensure the memory consumption is limited.
THROW/BREAKpinot.query.join.overflow.mode=THROWSET joinOverflowMode='THROW'join_overflow_mode='THROW'pinot.query.join.max.rows=100000SET maxRowsInJoin=1000000max_rows_in_join='1000000'joinOverflowMode = BREAK;TODO: Support size based limit.
Examples:
Sample screenshot for:

0. Normal run without limit hit: (Joined result is 47735)
More examples of difference between the threshold, and overflow mode:


