Make PinotTableRestletResourceTest java8 compatible#11287
Merged
mcvsubbu merged 1 commit intoapache:masterfrom Aug 7, 2023
Merged
Make PinotTableRestletResourceTest java8 compatible#11287mcvsubbu merged 1 commit intoapache:masterfrom
mcvsubbu merged 1 commit intoapache:masterfrom
Conversation
This commit fixes java8 build compatibility that is broken in apache#11017 Specifically, `Map.of` is only available in java 9+. In this case, this code: ```java TableConfigBuilder(TableType.REALTIME) .setStreamConfigs(Map.of("stream.type", "foo", "consumer.type", "lowlevel")); ``` Is actually not used since we are later calling the following in setup: ```java StreamConfig streamConfig = FakeStreamConfigUtils.getDefaultLowLevelStreamConfigs(); _realtimeBuilder...setStreamConfigs(streamConfig.getStreamConfigsMap()); ```
jtao15
approved these changes
Aug 7, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11287 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2229 2230 +1
Lines 119969 120138 +169
Branches 18186 18218 +32
==========================================
Hits 137 137
- Misses 119812 119981 +169
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcvsubbu
approved these changes
Aug 7, 2023
s0nskar
pushed a commit
to s0nskar/pinot
that referenced
this pull request
Aug 10, 2023
This commit fixes java8 build compatibility that is broken in apache#11017 Specifically, `Map.of` is only available in java 9+. In this case, this code: ```java TableConfigBuilder(TableType.REALTIME) .setStreamConfigs(Map.of("stream.type", "foo", "consumer.type", "lowlevel")); ``` Is actually not used since we are later calling the following in setup: ```java StreamConfig streamConfig = FakeStreamConfigUtils.getDefaultLowLevelStreamConfigs(); _realtimeBuilder...setStreamConfigs(streamConfig.getStreamConfigsMap()); ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes java8 build compatibility that is broken in #11017
Specifically,
Map.ofis only available in java 9+.In this case, this code:
Is actually not used since we are later calling the following in setup: