[multistage][agg] support agg with filter#11144
Merged
walterddr merged 4 commits intoapache:masterfrom Jul 28, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11144 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2223 2225 +2
Lines 119273 119588 +315
Branches 18055 18109 +54
==========================================
Hits 137 137
- Misses 119116 119431 +315
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
force-pushed
the
pr_add_agg_filter
branch
from
0f55841 to
4c0165d
Compare
walterddr
commented
Jul 21, 2023
Contributor
Author
There was a problem hiding this comment.
i dont know if this is the best API in DataBlockUtils to extract this. alternative is to extract the filter booleans and the IntValues separately, but i cannot make this change individually without changing how agg functions work.
Contributor
There was a problem hiding this comment.
Is it possible to create a FilteredTransferableBlock wrapping up TransferableBlock for AggregateOperator and others to use?
Contributor
There was a problem hiding this comment.
Feeling shouldn't use these many if-else checks
walterddr
force-pushed
the
pr_add_agg_filter
branch
from
4c0165d to
b18b6fd
Compare
Jackie-Jiang
approved these changes
Jul 28, 2023
walterddr
added a commit
that referenced
this pull request
Jul 29, 2023
s0nskar
pushed a commit
to s0nskar/pinot
that referenced
this pull request
Aug 10, 2023
* [init][agg] support agg filter where clause * limitation still applies for nullable vs non-nullable results and agg filter merging with select filter, will be address in follow ups. --------- Co-authored-by: Rong Rong <rongr@startree.ai>
s0nskar
pushed a commit
to s0nskar/pinot
that referenced
this pull request
Aug 10, 2023
enable theta sketch test for v2 after apache#11144 and apache#11153 Co-authored-by: Rong Rong <rongr@startree.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support syntax
AGG_FUN(...) FILTER (WHERE ...), such as:SELECT sum(val) FILTER (WHERE col > 10) FROM tblFollow ups
Major
IS NULLandIS NOT NULLas agg filter is not supportedSELECT COUNT(*) FILTER (WHERE a = 1 OR a = 2) FROM tbl WHERE a = 2will result in a compilation errorMinor
ServerPlanRequestVisitor: agg with filter and group-by causes conversion issue on v1 if the group-by field is not in the select list -- work around: selecting out all the group-by fieldsINclause not supported: FILTER WHERE clause with IN hard-wired to translate into subquery in calcite for some reason -- work around: use OR and equal