Skip to content

Funnel Count - Multiple Strategies (no partitioning requisites) #11092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atris merged 8 commits into from
Aug 30, 2023
Merged

Funnel Count - Multiple Strategies (no partitioning requisites) #11092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ff0db6f
FUNNEL_COUNT - aggregation strategies
darioliberman Jun 24, 2023
6d3f9fa
FUNNEL_COUNT - Aggregation Strategies Tests
darioliberman Jul 12, 2023
43c6de4
FUNNEL_COUNT - Aggregation Strategies Tests
darioliberman Jul 12, 2023
8b5d282
Refactor: Move strategy greation into a factory, make funnel count ag…
dario-liberman Aug 11, 2023
70c6214
Add license headers
dario-liberman Aug 11, 2023
f2b7046
Simplify factory by postponing strategy construction and templetizing…
dario-liberman Aug 11, 2023
7c06a72
Fix linter errors
dario-liberman Aug 11, 2023
7e3ae78
Merge branch 'apache:master' into funnel-strategies
dario-liberman Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ain/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import org.apache.datasketches.tuple.aninteger.IntegerSummary;
import org.apache.pinot.common.request.context.ExpressionContext;
import org.apache.pinot.common.request.context.FunctionContext;
import org.apache.pinot.core.query.aggregation.function.funnel.FunnelCountAggregationFunctionFactory;
import org.apache.pinot.segment.spi.AggregationFunctionType;
import org.apache.pinot.spi.data.FieldSpec.DataType;
import org.apache.pinot.spi.exception.BadQueryRequestException;
Expand Down Expand Up @@ -352,7 +353,7 @@ public static AggregationFunction getAggregationFunction(FunctionContext functio
throw new IllegalArgumentException(
"Aggregation function: " + function + " is only supported in selection without alias.");
case FUNNELCOUNT:
return new FunnelCountAggregationFunction(arguments);
return new FunnelCountAggregationFunctionFactory(arguments).get();

default:
throw new IllegalArgumentException();
Expand Down
Loading