[Do not merge] This is just a fake PR to run the tests#10857
Closed
gortiz wants to merge 74 commits intoapache:masterfrom
Closed
[Do not merge] This is just a fake PR to run the tests#10857gortiz wants to merge 74 commits intoapache:masterfrom
gortiz wants to merge 74 commits intoapache:masterfrom
Conversation
gortiz
force-pushed
the
always-unsafe-buffers
branch
from
ec59b45 to
c0c3463
Compare
Codecov Report
@@ Coverage Diff @@
## master #10857 +/- ##
=============================================
- Coverage 34.52% 0.11% -34.41%
=============================================
Files 2174 2186 +12
Lines 116848 117315 +467
Branches 17692 17722 +30
=============================================
- Hits 40339 137 -40202
- Misses 72991 117158 +44167
+ Partials 3518 20 -3498
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1006 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gortiz
force-pushed
the
always-unsafe-buffers
branch
from
c0c3463 to
121be3e
Compare
… 20 foreign memory api
Spotless doesn't like the suppression comments
Now that pinot-segment-spi uses sun.misc.unsafe, in order to compile with JDK 11 and --release 8 we would need to supply --bootstrap <path to JDK 8>
…tless. These checks are already executed by the linter job
…Upgraded to 3.14.1.
While -DskipTests skips the test execution, -Dmaven.test.skip=true also skips the compilation. This is necessary in cases where we use libraries that only work in Java > 11. Alternativelly we could use profiles to change the dependencies, but that would make the compilation process more complex
…uffer.factory is not set
gortiz
force-pushed
the
always-unsafe-buffers
branch
from
121be3e to
59df06f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a test for #10528. The code is the same, but it always uses the unsafe buffer library