Skip to content

[DO NOT MERGE] Always use LArray buffer in order to verify a bug #10774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gortiz wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[DO NOT MERGE] Always use LArray buffer in order to verify a bug #10774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e71a29
Always use LArray buffer in order to verify a bug
gortiz May 17, 2023
a22275b
Ignoring a test in PinotDataBufferTest.
gortiz May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/PinotDataBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,15 +111,15 @@ public String toString() {
public static PinotDataBuffer allocateDirect(long size, ByteOrder byteOrder, @Nullable String description) {
PinotDataBuffer buffer;
try {
if (size <= Integer.MAX_VALUE) {
buffer = PinotByteBuffer.allocateDirect((int) size, byteOrder);
} else {
// if (size <= Integer.MAX_VALUE) {
// buffer = PinotByteBuffer.allocateDirect((int) size, byteOrder);
// } else {
if (byteOrder == NATIVE_ORDER) {
buffer = PinotNativeOrderLBuffer.allocateDirect(size);
} else {
buffer = PinotNonNativeOrderLBuffer.allocateDirect(size);
}
}
// }
} catch (Exception e) {
LOGGER
.error("Caught exception while allocating direct buffer of size: {} with description: {}", size, description,
Expand All @@ -144,15 +144,15 @@ public static PinotDataBuffer loadFile(File file, long offset, long size, ByteOr
throws IOException {
PinotDataBuffer buffer;
try {
if (size <= Integer.MAX_VALUE) {
buffer = PinotByteBuffer.loadFile(file, offset, (int) size, byteOrder);
} else {
// if (size <= Integer.MAX_VALUE) {
// buffer = PinotByteBuffer.loadFile(file, offset, (int) size, byteOrder);
// } else {
if (byteOrder == NATIVE_ORDER) {
buffer = PinotNativeOrderLBuffer.loadFile(file, offset, size);
} else {
buffer = PinotNonNativeOrderLBuffer.loadFile(file, offset, size);
}
}
// }
} catch (Exception e) {
LOGGER.error("Caught exception while loading file: {} from offset: {} of size: {} with description: {}",
file.getAbsolutePath(), offset, size, description, e);
Expand Down Expand Up @@ -187,15 +187,15 @@ public static PinotDataBuffer mapFile(File file, boolean readOnly, long offset,
throws IOException {
PinotDataBuffer buffer;
try {
if (size <= Integer.MAX_VALUE) {
buffer = PinotByteBuffer.mapFile(file, readOnly, offset, (int) size, byteOrder);
} else {
// if (size <= Integer.MAX_VALUE) {
// buffer = PinotByteBuffer.mapFile(file, readOnly, offset, (int) size, byteOrder);
// } else {
if (byteOrder == NATIVE_ORDER) {
buffer = PinotNativeOrderLBuffer.mapFile(file, readOnly, offset, size);
} else {
buffer = PinotNonNativeOrderLBuffer.mapFile(file, readOnly, offset, size);
}
}
// }
} catch (Exception e) {
LOGGER.error("Caught exception while mapping file: {} from offset: {} of size: {} with description: {}",
file.getAbsolutePath(), offset, size, description, e);
Expand Down
2 changes: 1 addition & 1 deletion pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/memory/PinotDataBufferTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ public void testMultipleClose()
}
}

@Test
@Test(enabled = false)
public void testConstructors()
throws Exception {
testBufferStats(0, 0, 0, 0);
Expand Down