Skip to content

Enable case insensitivity by default #10771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jackie-Jiang merged 7 commits into from
Jun 13, 2023
Merged

Enable case insensitivity by default #10771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c117331
Enabling case insensitivity be default
soumitra-st May 16, 2023
3ebede2
Undo change for v2 engine
soumitra-st May 16, 2023
6b4aa6f
Undo change to ENABLE_CASE_INSENSITIVE_KEY
soumitra-st May 20, 2023
6b0ffa1
If any of case insensitive properties (enable.case.insensitive, enabl…
soumitra-st May 20, 2023
8629de6
Defined constant for default case insensitivity property, making sure…
soumitra-st May 22, 2023
ca6c8b3
Removed deprecated property enable.case.insensitive.pql
soumitra-st May 28, 2023
ae4d0e3
caseInsensitive should be true by default
soumitra-st Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,7 @@ public void start()
// Initialize FunctionRegistry before starting the broker request handler
FunctionRegistry.init();
boolean caseInsensitive =
_brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, false) || _brokerConf.getProperty(
Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY, false);
_brokerConf.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY, Helix.DEFAULT_ENABLE_CASE_INSENSITIVE);
TableCache tableCache = new TableCache(_propertyStore, caseInsensitive);
// Configure TLS for netty connection to server
TlsConfig tlsDefaults = TlsUtils.extractTlsConfig(_brokerConf, Broker.BROKER_TLS_PREFIX);
Expand Down
7 changes: 3 additions & 4 deletions ...oller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,9 @@ public void onInstanceConfigChange(List<InstanceConfig> instanceConfigs, Notific
HelixConfigScope helixConfigScope =
new HelixConfigScopeBuilder(HelixConfigScope.ConfigScopeProperty.CLUSTER).forCluster(_helixClusterName).build();
Map<String, String> configs = _helixAdmin.getConfig(helixConfigScope,
Arrays.asList(Helix.ENABLE_CASE_INSENSITIVE_KEY, Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
boolean caseInsensitive =
Boolean.parseBoolean(configs.get(Helix.ENABLE_CASE_INSENSITIVE_KEY)) || Boolean.parseBoolean(
configs.get(Helix.DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY));
Arrays.asList(Helix.ENABLE_CASE_INSENSITIVE_KEY));
boolean caseInsensitive = Boolean.parseBoolean(configs.getOrDefault(Helix.ENABLE_CASE_INSENSITIVE_KEY,
Boolean.toString(Helix.DEFAULT_ENABLE_CASE_INSENSITIVE)));
_tableCache = new TableCache(_propertyStore, caseInsensitive);
}

Expand Down
2 changes: 1 addition & 1 deletion ...controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ private static void setupHelixClusterIfNeeded(String helixClusterName, String zk
new HelixConfigScopeBuilder(ConfigScopeProperty.CLUSTER).forCluster(helixClusterName).build();
Map<String, String> configMap = new HashMap<>();
configMap.put(ZKHelixManager.ALLOW_PARTICIPANT_AUTO_JOIN, Boolean.toString(true));
configMap.put(ENABLE_CASE_INSENSITIVE_KEY, Boolean.toString(false));
configMap.put(ENABLE_CASE_INSENSITIVE_KEY, Boolean.toString(DEFAULT_ENABLE_CASE_INSENSITIVE));
configMap.put(DEFAULT_HYPERLOGLOG_LOG2M_KEY, Integer.toString(DEFAULT_HYPERLOGLOG_LOG2M));
configMap.put(CommonConstants.Broker.CONFIG_OF_ENABLE_QUERY_LIMIT_OVERRIDE, Boolean.toString(false));
admin.setConfig(configScope, configMap);
Expand Down
3 changes: 1 addition & 2 deletions pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,9 @@ public static class Helix {
public static final String LEAD_CONTROLLER_RESOURCE_ENABLED_KEY = "RESOURCE_ENABLED";

public static final String ENABLE_CASE_INSENSITIVE_KEY = "enable.case.insensitive";
public static final boolean DEFAULT_ENABLE_CASE_INSENSITIVE = true;
public static final String ALLOW_TABLE_NAME_WITH_DATABASE = "allow.table.name.with.database";
public static final boolean DEFAULT_ALLOW_TABLE_NAME_WITH_DATABASE = false;
@Deprecated
public static final String DEPRECATED_ENABLE_CASE_INSENSITIVE_KEY = "enable.case.insensitive.pql";

public static final String DEFAULT_HYPERLOGLOG_LOG2M_KEY = "default.hyperloglog.log2m";
public static final int DEFAULT_HYPERLOGLOG_LOG2M = 8;
Expand Down