[multistage] Run ExpandSearch Rule After All Filter Pushdown Rules#10627
Merged
walterddr merged 2 commits intoapache:masterfrom Apr 18, 2023
Merged
[multistage] Run ExpandSearch Rule After All Filter Pushdown Rules#10627walterddr merged 2 commits intoapache:masterfrom
walterddr merged 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10627 +/- ##
=============================================
+ Coverage 24.49% 68.58% +44.08%
- Complexity 49 6498 +6449
=============================================
Files 2090 2106 +16
Lines 112578 113074 +496
Branches 16972 17042 +70
=============================================
+ Hits 27578 77553 +49975
+ Misses 82089 30001 -52088
- Partials 2911 5520 +2609
Flags with carried forward coverage won't be shown. Click here to find out more. see 1508 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
reviewed
Apr 17, 2023
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
this actually make ense.
| { | ||
| "psql": "7.2.1.3", | ||
| "description": "sub-query to multiple anti semi-join queries with star results, using NOT IN clause", | ||
| "sql": "SELECT * FROM {tbl1} WHERE (num > -10 and num < 10) AND (name NOT IN (SELECT val FROM {tbl2} WHERE num = 3)) AND (name NOT IN (SELECT val from {tbl2} WHERE num = 4))" |
Contributor
There was a problem hiding this comment.
could you add additional test for the range predicate also inside the NOT-IN subquery?
Contributor
Author
There was a problem hiding this comment.
Done. Can you check again?
walterddr
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10409 I had added support for properly supporting predicate pushdown. However it introduced a bug where we could get "Range is not implemented yet" error because the filter pushdown rules could create a Sarg of their own.
This can be reproduced using the COLOCATED_JOIN Quickstart with the following query. It can also be reproduced using the unit-test case I have added.
cc: @walterddr