[WIP]: 10513 - Null support in Case/When queries.#10514
[WIP]: 10513 - Null support in Case/When queries.#10514abhioncbr wants to merge 16 commits intoapache:masterfrom
Conversation
abhioncbr
commented
Mar 31, 2023
abhioncbr
commented
- Null support in Case/When queries.
Codecov Report
@@ Coverage Diff @@
## master #10514 +/- ##
=============================================
- Coverage 64.32% 13.89% -50.43%
+ Complexity 6444 439 -6005
=============================================
Files 2050 2052 +2
Lines 110311 110394 +83
Branches 16684 16704 +20
=============================================
- Hits 70953 15336 -55617
- Misses 34215 93799 +59584
+ Partials 5143 1259 -3884
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1410 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| } else if (rexNode instanceof RexLiteral) { | ||
| RexLiteral rexLiteral = ((RexLiteral) rexNode); | ||
| FieldSpec.DataType dataType = RelToStageConverter.convertToFieldSpecDataType(rexLiteral.getType()); | ||
| //Added to set the DataType as UNKNOWN |
There was a problem hiding this comment.
@61yao, After setting the UNKNOWN datatype, the value gets set as String null., which later fails for the Numeric data type.
I think you have made some changes in a couple of your PR. Do you think, once your PR will be merged this works fine?
There was a problem hiding this comment.
This is v2 engine code. @walterddr should have a better understanding of this. My code only deals with v1 path.
There was a problem hiding this comment.
@walterddr do you think your PR is required here to merge before your change? Right now, it's failing because null is getting set as 'null' literal.
3 participants
