[multistage] fix mailbox cancel race condition#10432
Merged
xiangfu0 merged 1 commit intoapache:masterfrom Mar 16, 2023
Merged
Conversation
walterddr
commented
Mar 16, 2023
| @Override | ||
| public void complete() | ||
| throws Exception { | ||
| // TODO: should wait for _mailboxContentStreamObserver.onNext() finish before calling onComplete(). |
Contributor
Author
There was a problem hiding this comment.
I think currently it is guaranteed that onComplete is called after all onNext() --> implicitly via the OpChain scheduler. however we should still fix this systematically
Codecov Report
@@ Coverage Diff @@
## master #10432 +/- ##
=============================================
- Coverage 63.23% 35.22% -28.01%
+ Complexity 5068 282 -4786
=============================================
Files 2028 2053 +25
Lines 110632 111405 +773
Branches 16847 16940 +93
=============================================
- Hits 69955 39240 -30715
- Misses 35505 68753 +33248
+ Partials 5172 3412 -1760
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1434 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ankitsultana
approved these changes
Mar 16, 2023
xiangfu0
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #10424 for more details
this is another attempt to address the problem discovered in #10417