Refactor: Pass context instead on individual arguments to operator#10413
Merged
walterddr merged 12 commits intoapache:masterfrom Mar 16, 2023
Merged
Refactor: Pass context instead on individual arguments to operator#10413walterddr merged 12 commits intoapache:masterfrom
walterddr merged 12 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@walterddr I have changed test classes as well and removed the older constructor. Let me know if you want me to revert that. |
Codecov Report
@@ Coverage Diff @@
## master #10413 +/- ##
============================================
- Coverage 64.25% 64.23% -0.02%
- Complexity 6059 6094 +35
============================================
Files 1997 2000 +3
Lines 108768 108966 +198
Branches 16620 16646 +26
============================================
+ Hits 69888 69994 +106
- Misses 33816 33877 +61
- Partials 5064 5095 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 80 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
KKcorps
force-pushed
the
query_operator_refactor_context
branch
from
2943150 to
a28ebbb
Compare
somandal
reviewed
Mar 13, 2023
...uery-runtime/src/main/java/org/apache/pinot/query/runtime/plan/OperatorExecutionContext.java
Outdated
Show resolved
Hide resolved
walterddr
reviewed
Mar 13, 2023
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
lgtm mostly. please address the comments
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/PlanRequestContext.java
Outdated
Show resolved
Hide resolved
...uery-runtime/src/main/java/org/apache/pinot/query/runtime/plan/OperatorExecutionContext.java
Outdated
Show resolved
Hide resolved
...-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java
Outdated
Show resolved
Hide resolved
...t-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java
Outdated
Show resolved
Hide resolved
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/FilterOperator.java
Show resolved
Hide resolved
...uery-runtime/src/main/java/org/apache/pinot/query/runtime/plan/OperatorExecutionContext.java
Outdated
Show resolved
Hide resolved
…ailboxReceiveOperator
KKcorps
commented
Mar 14, 2023
...ry-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxReceiveOperator.java
Outdated
Show resolved
Hide resolved
walterddr
reviewed
Mar 15, 2023
...t-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java
Outdated
Show resolved
Hide resolved
walterddr
reviewed
Mar 15, 2023
...ry-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxReceiveOperator.java
Outdated
Show resolved
Hide resolved
walterddr
reviewed
Mar 15, 2023
Contributor
walterddr
left a comment
walterddr
left a comment
There was a problem hiding this comment.
lgtm mostly. please kindly take a look at the comments.
also several general points.
- let's not auto-reformat just to make the PR easier to review
- for the context object. can we put it as first argument?
KKcorps
force-pushed
the
query_operator_refactor_context
branch
from
5820651 to
f87d991
Compare
KKcorps
requested review from
somandal and
walterddr
and removed request for
somandal
somandal
reviewed
Mar 15, 2023
Comment on lines
+90
to
+91
| // OpChainExecutionContext context = | ||
| // OperatorTestUtil.getContext(1, DEFAULT_SENDER_STAGE_ID, new VirtualServerAddress(_server)); |
Contributor
There was a problem hiding this comment.
looks like commented out code. can you clean this up?
Contributor
|
@KKcorps can you address this:
|
Contributor
Author
walterddr
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to easily add more params to operators constructors in the future without major refactoring.