[multistage] Initial (phase 1) query planner support for window functions#10228
Merged
siddharthteotia merged 4 commits intoapache:masterfrom Feb 8, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10228 +/- ##
============================================
- Coverage 70.43% 70.42% -0.01%
+ Complexity 5759 5100 -659
============================================
Files 2016 2017 +1
Lines 109154 109153 -1
Branches 16583 16594 +11
============================================
- Hits 76881 76874 -7
+ Misses 26894 26892 -2
- Partials 5379 5387 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…clause for window functions
walterddr
approved these changes
Feb 7, 2023
Contributor
walterddr
left a comment
There was a problem hiding this comment.
lgtm overall. I am sure the runtime PR will require some changes on this so let's follow up on the runtime PR once finishes.
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/stage/WindowNode.java
Show resolved
Hide resolved
siddharthteotia
approved these changes
Feb 8, 2023
This was referenced Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the multi-stage planner changes to support Phase 1 of Window Functions. Planning support has been added for the following classes of window queries:
The window functions supported as part of Phase 1 are: SUM, AVG, MIN, MAX, and COUNT
This PR also adds JSON files for planner test cases which can be extended for an exhaustive set of query types.
This PR does not include support for:
The above will be part of future changes for window function support
cc @siddharthteotia @walterddr @Jackie-Jiang