-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Open
Description
what's the problem?
Return a unique requestId always is important for tracing/debugging, to find related logging events for example. There're some limitation at the moment:
- it's not available to every queries in broker, only
MultiStageBrokerRequestHandlergenerates one and included inBrokerResponseNativeV2; - In java-client,
org.apache.pinot.client.BrokerResponseis a reduced set oforg.apache.pinot.common.response.BrokerResponse,requestIdis lost with many other metadata fields;
Proposed changes
To address these limitations, I would like to suggest some changes as below:
- generate
requestIdin PinotClientRequest.java, and add a new fieldrequestIdinorg.apache.pinot.common.response.BrokerResponse; - remove
org.apache.pinot.client.BrokerResponseand useresponse.BrokerResponsedirectly;
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels