Skip to content

returns requestId for each broker query request #10884

@mingmxu

Description

@mingmxu

what's the problem?

Return a unique requestId always is important for tracing/debugging, to find related logging events for example. There're some limitation at the moment:

  1. it's not available to every queries in broker, onlyMultiStageBrokerRequestHandler generates one and included in BrokerResponseNativeV2;
  2. In java-client, org.apache.pinot.client.BrokerResponse is a reduced set of org.apache.pinot.common.response.BrokerResponse, requestId is lost with many other metadata fields;

Proposed changes

To address these limitations, I would like to suggest some changes as below:

  • generate requestId in PinotClientRequest.java, and add a new field requestId in org.apache.pinot.common.response.BrokerResponse;
  • remove org.apache.pinot.client.BrokerResponse and use response.BrokerResponse directly;

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions