Apply compat changes from latest Pekko #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
force-pushed
the
apply-compat-changes-latest-pekko
branch
from
d76ea3f
to
61439a8
Compare
This was referenced May 10, 2023
mdedetrich
force-pushed
the
apply-compat-changes-latest-pekko
branch
from
61439a8
to
7e979c6
Compare
mdedetrich
requested review from
jrudolph,
gmethvin,
He-Pin,
nvollmar,
seglo and
pjfanning
|
@pjfanning @nvollmar @He-Pin PR is now ready, all of the dependencies have also been updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only notable change here is that I had to move a single source file
docs.javadsl.CassandraSessionSpectoorg.apache.pekko.stream.connectors.cassandra.javadsl.CassandraSessionSpec. This is because the new compatFutureConverters/OptionConvertersfunctions are package private withinorg.apache.pekko.Normally source files that reside within
docs.javadsl/docs.scaladslare meant to be referenced in paradox docs, but forCassandraSessionSpecthis isn't the case. It just appears to be a standard test so it being put intodocs.javadslin the first place was likely an oversight/accident anyways.