PARQUET-758: Add files with Float16 column#40
Merged
pitrou merged 3 commits intoapache:masterfrom Nov 9, 2023
Merged
Conversation
|
apache/parquet-format#184 has now been merged, is this waiting on anything further? I'm mainly wondering what I should be doing with apache/arrow-rs#5003 |
pitrou
reviewed
Nov 9, 2023
data/README.md
Outdated
Comment on lines
48
to
49
| | float16_nonzeros_and_nans.parquet | Float16 (logical type) column with NaNs and nonzero finite min/max values | | ||
| | float16_zeros_and_nans.parquet | Float16 (logical type) column with NaNs and zeros as min/max values | |
Member
There was a problem hiding this comment.
Can you perhaps show how the file was generated, or how the data looks like, in the same spirit as was done for "NaN in stats" in below?
Member
|
@benibus Can you please update this and make it ready for review? It would be better to merge this soon, so that the file can be used for integration testing in implementation PRs. |
Contributor
Author
|
@pitrou Extended the docs in the README and marked as ready to review. I believe these files should be sufficient for our purposes - including apache/arrow-rs#5003 (sorry about the wait, @tustvold... that was my bad). |
pitrou
reviewed
Nov 9, 2023
pitrou
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files are dependent on the Float16 type proposal's acceptance: apache/parquet-format#184
They should be useful for testing several cases across Parquet implementations:
Generated with:
Output: