This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-932: Add option to build parquet library with minimal dependency #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2017 12:01
majetideepak
commented
Mar 30, 2017
| @@ -103,10 +103,14 @@ if ("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}") | |||
| option(PARQUET_RPATH_ORIGIN | |||
| "Build Parquet libraries with RATH set to \$ORIGIN" | |||
| OFF) | |||
| option(PARQUET_MINIMAL_DEPENDENCY | |||
| "Depend only on Thirdparty headers to build libparquet. Always OFF if building binaries" | |||
| OFF) | |||
There was a problem hiding this comment.
We could also implicitly set this value to OFF by default and set it to ON if PARQUET_BUILD_TESTS and PARQUET_BUILD_EXECUTABLES and PARQUET_BUILD_BENCHMARKS are all OFF
wesm
approved these changes
Mar 31, 2017
cmake_modules/FindArrow.cmake
Outdated
| set(ARROW_FOUND TRUE) | ||
| set(ARROW_HEADER_NAME arrow/arrow.h) |
| @@ -51,8 +51,10 @@ find_library(ARROW_IO_LIB_PATH NAMES arrow_io | |||
| ${ARROW_SEARCH_LIB_PATH} | |||
| NO_DEFAULT_PATH) | |||
|
|
|||
| if (ARROW_INCLUDE_DIR AND ARROW_LIB_PATH) | |||
| if (ARROW_INCLUDE_DIR AND (PARQUET_MINIMAL_DEPENDENCY OR ARROW_LIB_PATH)) | |||
There was a problem hiding this comment.
Just so I understand, you have a build environment where only the headers are available, and no libraries?
|
+1, merging this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users want to build only the parquet library, thirdparty headers are sufficient and GTEST and GBENCHMARK are not required.