Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

PARQUET-643: Add const modifier to schema pointer reference #128

Closed
wants to merge 1 commit into from
Closed

PARQUET-643: Add const modifier to schema pointer reference #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/parquet/file/writer-internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ void RowGroupSerializer::Close() {
// FileSerializer

std::unique_ptr<ParquetFileWriter::Contents> FileSerializer::Open(
std::shared_ptr<OutputStream> sink, std::shared_ptr<GroupNode>& schema,
std::shared_ptr<OutputStream> sink, const std::shared_ptr<GroupNode>& schema,
const std::shared_ptr<WriterProperties>& properties) {
std::unique_ptr<ParquetFileWriter::Contents> result(
new FileSerializer(sink, schema, properties));
Expand Down Expand Up @@ -249,7 +249,7 @@ void FileSerializer::WriteMetaData() {
}

FileSerializer::FileSerializer(std::shared_ptr<OutputStream> sink,
std::shared_ptr<GroupNode>& schema,
const std::shared_ptr<GroupNode>& schema,
const std::shared_ptr<WriterProperties>& properties)
: sink_(sink),
allocator_(properties->allocator()),
Expand Down
5 changes: 3 additions & 2 deletions src/parquet/file/writer-internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ class RowGroupSerializer : public RowGroupWriter::Contents {
class FileSerializer : public ParquetFileWriter::Contents {
public:
static std::unique_ptr<ParquetFileWriter::Contents> Open(
std::shared_ptr<OutputStream> sink, std::shared_ptr<schema::GroupNode>& schema,
std::shared_ptr<OutputStream> sink,
const std::shared_ptr<schema::GroupNode>& schema,
const std::shared_ptr<WriterProperties>& properties = default_writer_properties());

void Close() override;
Expand All @@ -128,7 +129,7 @@ class FileSerializer : public ParquetFileWriter::Contents {

private:
explicit FileSerializer(std::shared_ptr<OutputStream> sink,
std::shared_ptr<schema::GroupNode>& schema,
const std::shared_ptr<schema::GroupNode>& schema,
const std::shared_ptr<WriterProperties>& properties);

std::shared_ptr<OutputStream> sink_;
Expand Down
2 changes: 1 addition & 1 deletion src/parquet/file/writer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ ParquetFileWriter::~ParquetFileWriter() {
}

std::unique_ptr<ParquetFileWriter> ParquetFileWriter::Open(
std::shared_ptr<OutputStream> sink, std::shared_ptr<GroupNode>& schema,
std::shared_ptr<OutputStream> sink, const std::shared_ptr<GroupNode>& schema,
const std::shared_ptr<WriterProperties>& properties) {
auto contents = FileSerializer::Open(sink, schema, properties);

Expand Down
2 changes: 1 addition & 1 deletion src/parquet/file/writer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class ParquetFileWriter {
~ParquetFileWriter();

static std::unique_ptr<ParquetFileWriter> Open(std::shared_ptr<OutputStream> sink,
std::shared_ptr<schema::GroupNode>& schema,
const std::shared_ptr<schema::GroupNode>& schema,
const std::shared_ptr<WriterProperties>& properties = default_writer_properties());

void Open(std::unique_ptr<Contents> contents);
Expand Down