Draft
Conversation
5ce27f8 to
a59205f
Compare
3d68a64 to
541f746
Compare
c288568 to
1a5cd6f
Compare
4f54e5d to
186ed45
Compare
a0f9a9b to
d6b1fd1
Compare
7a9cd62 to
b57993e
Compare
JingsongLi
reviewed
Mar 5, 2026
|
|
||
| <dependency> | ||
| <groupId>org.apache.paimon</groupId> | ||
| <artifactId>paimon-lumina-jni</artifactId> |
Contributor
There was a problem hiding this comment.
com.aliyun.lumina
lumina-jni
JingsongLi
reviewed
Mar 5, 2026
| import scala.collection.JavaConverters._ | ||
|
|
||
| /** End-to-end tests for Lumina vector index read/write operations on Spark 3.5. */ | ||
| class LuminaVectorIndexE2ETest extends PaimonSparkTestBase { |
Contributor
There was a problem hiding this comment.
Just move these tests to spark-ut?
JingsongLi
reviewed
Mar 5, 2026
| <version>1.4-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>paimon-lumina</artifactId> |
Contributor
There was a problem hiding this comment.
Just one paimon-lumina is OK, no need to have index and e2e.
JingsongLi
reviewed
Mar 5, 2026
| <version>1.4-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>paimon-lumina</artifactId> |
Contributor
There was a problem hiding this comment.
Please create a README.md to this, explain what is lumina.
33d5790 to
209a6f7
Compare
b1c8d5b to
75f8125
Compare
75f8125 to
39e16c1
Compare
09c15d8 to
c3417b3
Compare
dac4edd to
c4f0142
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
paimon-lumina/src/main/java/org/apache/paimon/lumina/index/LuminaVectorGlobalIndexWriter.java
Outdated
Show resolved
Hide resolved
...spark/paimon-spark-ut/src/test/scala/org/apache/paimon/spark/sql/LuminaVectorIndexTest.scala
Outdated
Show resolved
Hide resolved
paimon-lumina/src/main/java/org/apache/paimon/lumina/index/LuminaVectorGlobalIndexReader.java
Outdated
Show resolved
Hide resolved
...spark/paimon-spark-ut/src/test/scala/org/apache/paimon/spark/sql/LuminaVectorIndexTest.scala
Outdated
Show resolved
Hide resolved
...spark/paimon-spark-ut/src/test/scala/org/apache/paimon/spark/sql/LuminaVectorIndexTest.scala
Outdated
Show resolved
Hide resolved
* upstream/master: (31 commits) [python] Correct pyroaring version in requirements [test] Enrich table name in MergeIntoTableTestBase [test] Fix unstable test: FileStoreLookupFunctionTest.testLookupScanLeak [python] Remove useless parameters in blob_writer.py [rest] Introduce reset consumer api in rest (apache#7372) [python] Introduce Python CLI table snapshot (apache#7373) [python] Fix time mapping by always using time32 (apache#7371) [python] Introduce catalog list-dbs in Python CLI (apache#7366) [hotfix][docs] replace the documentation URL for data-types blob (apache#7370) [python] Add i short name to ignore-if-not-exists for database [python] Support dynamic bucket write (apache#7363) [python] Introduce database related commands to Python CLI (apache#7362) [python] Introduce table import, drop and alter to Python CLI (apache#7360) [python] Fix py version required in README (apache#7361) [test] Add missing LeafFunction coverage in PredicateJsonSerdeTest (apache#7359) [python] support predicate NotBetween, Like function (apache#7352) [python] Introduce Paimon CLI in PyPaimon (apache#7358) [doc] Document ignoreIfExists for create_branch [core] Add IF NOT EXISTS support for create_branch operation (apache#7353) [python] Remove oss and pylance from requirements deps ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce a new
paimon-luminamodule that integrates Lumina as a vector index backend for Apache Paimon's global index framework.Lumina is a DiskANN graph-based approximate nearest neighbor (ANN) search library developed by
the Alibaba Storage Service Team. It is accessed from Java via JNI through the
lumina-jniartifact.
Tests
API and Format
Documentation
Added
paimon-lumina/README.mdexplaining the module purpose, supported index types, metrics,and all configuration options.
Generative AI tooling