[core] Fix chain table partition listing under data filters.#7268
Open
JunRuiLee wants to merge 2 commits intoapache:masterfrom
Open
[core] Fix chain table partition listing under data filters.#7268JunRuiLee wants to merge 2 commits intoapache:masterfrom
JunRuiLee wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Hi @Aitozi , could you please help review this PR? Thanks! |
JunRuiLee
force-pushed
the
fix-chain-table-1
branch
from
521e5b1 to
b1e7e07
Compare
Contributor
Author
|
Gentle ping @Aitozi for review when you have time. |
Contributor
|
Thanks @JunRuiLee for the fix, LGTM +1. Do you have any other comments for this? cc @JingsongLi @Stefanietry |
Contributor
|
I want to point another thing here, that the same problem should also exist in the Can you also create a fix for that, you can do that in another PR. @JunRuiLee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix incorrect results for chain table reads with non‑partition filters.
Expected behavior is that chain reads enumerate partitions using only partition predicates, while non‑partition filters apply only when reading splits within each partition.
The current implementation calls
listPartitions()on a scan that already applies data filters, so partition listing gets pruned by non‑partition predicates. This can skip fallback partitions and yield empty or incomplete results.Tests