[core]Add schema validation for record-level.time-field #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Dec 23, 2024
| @@ -176,6 +181,35 @@ public static void validateTableSchema(TableSchema schema) { | |||
| } | |||
| } | |||
|
|
|||
| if (schema.options().containsKey(CoreOptions.RECORD_LEVEL_TIME_FIELD.key())) { | |||
There was a problem hiding this comment.
String recordLevelTimeField = options.recordLevelTimeField();
if (recordLevelTimeField != null) {
xxx;
}
|
|
||
| @Test | ||
| public void testRecordLevelTimeField() { | ||
| Map<String, String> options = new HashMap<>(); |
There was a problem hiding this comment.
Map<String, String> options = new HashMap<>(2);
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class RecordLevelExpireTest extends PrimaryKeyTableTestBase { | ||
| @Override |
There was a problem hiding this comment.
Please add a blank line before @OverRide.
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class RecordLevelExpireTest extends PrimaryKeyTableTestBase { | ||
| @Override | ||
| @BeforeEach | ||
| public void beforeEachBase() throws Exception { |
There was a problem hiding this comment.
Column "col1" datatype is DataTypes.INT() in PrimaryKeyTableTestBase, but it should be DataTypes.INT().notNull() in RecordLevelExpireTest.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add schema validation for record-level.time-field
Linked issue: close #4724
Tests
API and Format
Documentation