Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Unify FileRecordReader and reduce file access #3098

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[core] Unify FileRecordReader and reduce file access #3098

merged 1 commit into from
Mar 26, 2024

Conversation

JingsongLi
Copy link
Contributor

Purpose

  1. KeyValueDataFileRecordReader should just use FileRecordReader.
  2. FileUtils.checkExists should just in exception path to reduce file access.

Tests

API and Format

Documentation

leaves12138
leaves12138 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@leaves12138 leaves12138 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 466de5a into apache:master Mar 26, 2024
8 of 9 checks passed
zhu3pang pushed a commit to zhu3pang/incubator-paimon that referenced this pull request Mar 29, 2024
@JingsongLi @zhu3pang
[core] Unify FileRecordReader and reduce file access (apache#3098)
7f27f04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaves12138 leaves12138 leaves12138 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JingsongLi @leaves12138