[core] File index interface and file format. #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Mar 21, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexPredicateTester.java
Outdated
Show resolved
Hide resolved
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexFunctionVisitor.java
Outdated
Show resolved
Hide resolved
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexPredicateUtil.java
Outdated
Show resolved
Hide resolved
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexPredicateUtil.java
Outdated
Show resolved
Hide resolved
paimon-common/src/main/java/org/apache/paimon/fileindex/ObjectToBytesVisitor.java
Outdated
Show resolved
Hide resolved
added 13 commits
March 26, 2024 15:25
leaves12138
changed the title
zyl891229
reviewed
Mar 27, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexFile.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 27, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexFile.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 27, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexFile.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 27, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexFile.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 27, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexFile.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 27, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexFile.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 27, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexPredicate.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 27, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexPredicate.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Mar 27, 2024
paimon-common/src/main/java/org/apache/paimon/fileindex/FileIndexReader.java
Outdated
Show resolved
Hide resolved
zyl891229
reviewed
Mar 27, 2024
| // writeColumnSize | ||
| dataOutputStream.writeInt(bodyInfo.size()); | ||
| // writeColumnInfo, offset = headLength | ||
| for (Map.Entry<String, Pair<Integer, Integer>> entry : bodyInfo.entrySet()) { |
There was a problem hiding this comment.
can we sort the key when write and use an algorithm (e.g. binary search) to speed up the search when read
in case of the large number of keys
There was a problem hiding this comment.
We must read all head columns and put them into a hashmap not an array list, so we don't need to sort.
added 5 commits
March 27, 2024 14:51
|
+1 |
zhu3pang
pushed a commit
to zhu3pang/incubator-paimon
that referenced
this pull request
Mar 29, 2024
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to PIP-17 (https://cwiki.apache.org/confluence/display/PAIMON/PIP-17%3A+Introduce+secondary+column+index)
index file format:
REDUNDANT field for compatibility of next version.
var bytes (head) = bytes length + real bytes
var bytes (body) = column bytes + column bytes + ...