[Hive] Cache TableSchema into Configuration to avoid loading read scheme file in PaimonSerDe #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
wg1026688210
force-pushed
the
improve/reduce_nm_io
branch
from
5207f0a to
a160915
Compare
wg1026688210
changed the title
JingsongLi
reviewed
Mar 11, 2024
| @@ -192,7 +198,16 @@ public static HiveSchema extract(@Nullable Configuration configuration, Properti | |||
| return new HiveSchema(builder.build()); | |||
| } | |||
|
|
|||
| private static Optional<TableSchema> getExistingSchema( | |||
| @VisibleForTesting | |||
| static Optional<TableSchema> getTableSchemaFromCache(Properties properties) { | |||
There was a problem hiding this comment.
Why not just cache HiveSchema?
JingsongLi
reviewed
Mar 11, 2024
| @@ -192,7 +198,16 @@ public static HiveSchema extract(@Nullable Configuration configuration, Properti | |||
| return new HiveSchema(builder.build()); | |||
| } | |||
|
|
|||
| private static Optional<TableSchema> getExistingSchema( | |||
| @VisibleForTesting | |||
| static Optional<TableSchema> getTableSchemaFromCache(Properties properties) { | |||
There was a problem hiding this comment.
getSchemaFromProperties
zhu3pang
pushed a commit
to zhu3pang/incubator-paimon
that referenced
this pull request
Mar 29, 2024
…eme file in PaimonSerDe (apache#2946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The Map Task will fetch the tableschema of paimon. we cache the schema json to configuration to reduce the access of FileSystem
Linked issue: close #xxx
Tests
API and Format
Documentation