Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CDC]fix building schema from delete record #2635

Merged
merged 1 commit into from
Jan 8, 2024
Merged

[CDC]fix building schema from delete record #2635

merged 1 commit into from
Jan 8, 2024

Conversation

wg1026688210
Copy link
Contributor

@wg1026688210 wg1026688210 commented Jan 4, 2024 •
edited
Loading

Purpose

image

fix that kafka cdc action build schema fail from delete record

  1. Try to parse schema from delete record .
  2. Ignore exception to triger retry if parse schema still failed from delete record .

Tests

KafkaDebeziumWithSchemaSyncTableActionITCase#testKafkaBuildSchemaWithDelete

@wg1026688210 wg1026688210 changed the title [CDC]fix building schema from delete data [CDC]fix building schema from delete record Jan 4, 2024
@wg1026688210 wg1026688210 force-pushed the fix_build_schem_from_delete_error branch 2 times, most recently from ee2a484 to d184c14 Compare January 4, 2024 08:05
@yuzelin yuzelin self-requested a review January 4, 2024 08:10
@wg1026688210 wg1026688210 force-pushed the fix_build_schem_from_delete_error branch from d184c14 to a8a67a3 Compare January 4, 2024 08:27
@wg1026688210 wg1026688210 force-pushed the fix_build_schem_from_delete_error branch from a8a67a3 to fde2b3b Compare January 4, 2024 08:54
yuzelin
yuzelin approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@yuzelin yuzelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yuzelin yuzelin merged commit 75b1cf5 into apache:master Jan 8, 2024
9 checks passed
TaoZex pushed a commit to TaoZex/incubator-paimon that referenced this pull request Jan 8, 2024
@wg1026688210 @TaoZex
[cdc] Fix bug when building schema from delete record (apache#2635)
31b8bb3
hzjhjjyy pushed a commit to hzjhjjyy/incubator-paimon that referenced this pull request Jan 9, 2024
@wg1026688210 @hzjhjjyy
[cdc] Fix bug when building schema from delete record (apache#2635)
8bba58a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzelin yuzelin yuzelin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wg1026688210 @yuzelin