Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove un-used code in TableWriteImpl #2442

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[core] Remove un-used code in TableWriteImpl #2442

merged 1 commit into from
Dec 4, 2023

Conversation

leaves12138
Copy link
Contributor

@leaves12138 leaves12138 commented Dec 4, 2023 •
edited
Loading

Purpose

Remove un-used code

The field tableName in TableWriteImpl is never used. It is private and seems never to be used.

Tests

API and Format

Documentation

@JingsongLi
Copy link
Contributor

Please enrich title, what code you want to remove, and why..

@leaves12138 leaves12138 changed the title [core] Remove un-used code [core] Remove un-used code in TableWriteImpl Dec 4, 2023
JingsongLi
JingsongLi approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 33f8d5f into apache:master Dec 4, 2023
9 checks passed
JingsongLi pushed a commit that referenced this pull request Dec 5, 2023
@leaves12138 @JingsongLi
[core] Remove un-used code in TableWriteImpl (#2442)
2611fc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leaves12138 @JingsongLi