[core] Move convertToRawFiles method from TableScan to Split #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Nov 22, 2023
| } | ||
|
|
||
| @Override | ||
| public List<RawFile> rawFiles() { |
There was a problem hiding this comment.
We have two choices:
Optional<List<RawFile>> convertToRawFiles.boolean needsMerging()andList<RawFile> rawFiles(), if need to merge, rawFiles should throws exception.
Maybe choice first is better.
YannByron
reviewed
Nov 22, 2023
| @@ -89,6 +92,16 @@ public long rowCount() { | |||
| return rowCount; | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean needsMerging() { | |||
| return rawFiles.isEmpty(); | |||
There was a problem hiding this comment.
IMO, thinking about supporting chang-log tables for SR or Spark native engine, needsMerge should not depend on whether the list of rawFile is empty. We can depend on whether table is a change-log table or an append-on table for now. Further, even this's a change-log table, It should be judged by whether these documents overlap.
There was a problem hiding this comment.
Now, we just introduce method to Split, this is a common method, just for non-merging reading, we can try to add more to cover more cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It would be more natural to check if a split can be read without merging directly from that split, not from other sources.
This PR moves
convertToRawFilesmethod fromTableScantoSplit.Tests
This PR is a refactor. Existing tests should cover the correctness.
API and Format
No.
Documentation
No.