Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdc] Fix that initializing decimal type that missing precision will throw exception #2330

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[cdc] Fix that initializing decimal type that missing precision will throw exception #2330

merged 1 commit into from
Nov 16, 2023

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Nov 16, 2023

Purpose

The decimal type will validate that precision is between 1-38.

Tests

API and Format

KafkaCanalSyncTableActionITCase#testMissingDecimalPrecision

Documentation

JingsongLi
JingsongLi approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

JingsongLi
JingsongLi approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit f46d636 into apache:master Nov 16, 2023
@yuzelin yuzelin deleted the fix_decimal branch November 17, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuzelin @JingsongLi