[Core] support scan metrics #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnappi17
force-pushed
the
scan-metrics
branch
5 times, most recently
from
9b30db8 to
93c0223
Compare
schnappi17
force-pushed
the
scan-metrics
branch
from
93c0223 to
c825b34
Compare
schnappi17
force-pushed
the
scan-metrics
branch
from
7a48528 to
3911f93
Compare
tsreaper
reviewed
Nov 1, 2023
| Iterable<ManifestEntry> entries = | ||
| ParallellyExecuteUtils.parallelismBatchIterable( | ||
| files -> | ||
| files.parallelStream() | ||
| .filter(this::filterManifestFileMeta) | ||
| .flatMap(m -> readManifest.apply(m).stream()) | ||
| .filter(this::filterByStats) | ||
| .peek(e -> cntEntries.getAndIncrement()) |
There was a problem hiding this comment.
Why not directly increase cntEntries by the size of the collected list? If you use peek, cntEntries will be increased by every element in this list. Note that this stream is parallelized, so there will be many concurrent writes which affect the performance.
| @@ -247,6 +248,12 @@ public SnapshotReader withBucketFilter(Filter<Integer> bucketFilter) { | |||
| return this; | |||
| } | |||
|
|
|||
| @Override | |||
| public SnapshotReader withMetricRegistry(MetricRegistry registry) { | |||
| // won't register metric | |||
There was a problem hiding this comment.
Why not? AuditLogTable also scans from data file.
schnappi17
added a commit
to schnappi17/flink-table-store
that referenced
this pull request
Nov 8, 2023
This closes apache#2170.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2000