[Flink] Support numBytesSend metrics for paimon sink #1739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsreaper
reviewed
Aug 8, 2023
| for (CommitMessage commitMessage : commitMessages) { | ||
| long dataFileSizeInc = | ||
| ((CommitMessageImpl) commitMessage) | ||
| .newFilesIncrement().newFiles().stream() |
There was a problem hiding this comment.
Compact files and changelogs should also be calculated.
| throws IOException, InterruptedException { | ||
| metricGroup.getNumBytesOutCounter().inc(calcDataBytesSend(committables)); |
There was a problem hiding this comment.
Count this only after the commit is successful. Otherwise if the commit is retried through fail over, this will be counted multiple times.
tsreaper
approved these changes
Aug 9, 2023
schnappi17
added a commit
to schnappi17/flink-table-store
that referenced
this pull request
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1737
Update counter when commit with committables, the value is the size of data files. The counter metric is already registered by flink.