[core] Add test for histogram metric #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnappi17
force-pushed
the
add-test-histogram
branch
from
78c8515 to
4a90e67
Compare
tsreaper
reviewed
Jul 24, 2023
| * Abstract base class for testing {@link Histogram} and {@link HistogramStatistics} | ||
| * implementations. | ||
| */ | ||
| public class AbstractHistogramTest { |
There was a problem hiding this comment.
Why do we need an abstract test class? There is only one subclass of Histogram.
tsreaper
approved these changes
Jul 25, 2023
schnappi17
added a commit
to schnappi17/flink-table-store
that referenced
this pull request
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1617