HDDS-14572. ReInit DeletedBlocksTransactionSummary after SCM leader transfer

[ChenSammi]

What changes were proposed in this pull request?

ReInit DeletedBlocksTransactionSummary after SCM leader transfer.
Currently DeletedBlocksTransactionSummary is not reinited after SCM leader transfer. This is the reason of negative DeletedBlocksTransactionSummary value after leader transfer.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14572

How was this patch tested?

new unit tests

[priyeshkaratha]

Thanks @ChenSammi for the patch. Changes LGTM. Minor comments on logging.

[priyeshkaratha]

Suggested change

	LOG.warn("Failed to initialize Storage space distribution data. The feature will continue with current " +
	"totalBlockCount {}, totalBlockCount {}, totalBlocksSize {} and totalReplicatedBlocksSize {}. " +
	"There is a high chance that the real data and current data has a fixed gap.",
	totalBlockCount.get(), totalBlocksSize.get(), totalBlocksSize.get(), totalReplicatedBlocksSize.get());
	LOG.warn("Failed to initialize Storage space distribution data. The feature will continue with current " +
	"totalBlockCount {}, totalTxCount {}, totalBlocksSize {} and totalReplicatedBlocksSize {}. " +
	"There is a high chance that the real data and current data has a fixed gap.",
	totalBlockCount.get(), totalTxCount.get(), totalBlocksSize.get(), totalReplicatedBlocksSize.get());

[priyeshkaratha]

nit - totalBlocksSize used twice instead of totalTxCount

[priyeshkaratha]

Thanks @ChenSammi for updating the patch. LGTM

[ashishkumar50]

@ChenSammi Thanks for the patch, LGTM except a minor suggestion.

[ashishkumar50]

We can move this code to other method and call when there is leadertransfer instead using inside clear which is logically meant for clearing all the memory maps or alternatively just update the method name.

[ChenSammi]

Agree. Rename clear() to onBecomeLeader()

[ashishkumar50]

Thanks for updating patch, LGTM.

[ChenSammi]

Thanks @priyeshkaratha and @ashishkumar50 for the review.