HDDS-13844. Decouple DirectoryDeletingService delete batching from Ratis request size. #9270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 29, 2025 01:02
swamirishi
requested changes
Nov 10, 2025
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
thanks for the patch @aryangupta1998 left some review comments inline
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/DeleteKeysResult.java
Show resolved
Hide resolved
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Outdated
Show resolved
Hide resolved
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Outdated
Show resolved
Hide resolved
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Outdated
Show resolved
Hide resolved
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Outdated
Show resolved
Hide resolved
swamirishi
requested changes
Nov 10, 2025
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
left more review comments
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Show resolved
Hide resolved
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Outdated
Show resolved
Hide resolved
swamirishi
reviewed
Nov 10, 2025
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Outdated
Show resolved
Hide resolved
Contributor
|
@yandrey321 do you review the patch? |
aryangupta1998
changed the title
yandrey321
reviewed
Nov 10, 2025
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Show resolved
Hide resolved
yandrey321
reviewed
Nov 10, 2025
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Show resolved
Hide resolved
yandrey321
reviewed
Nov 10, 2025
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java
Outdated
Show resolved
Hide resolved
swamirishi
reviewed
Nov 11, 2025
Contributor
If the patch needs to be updated before merge, then please don't approve, since it's confusing. |
swamirishi
approved these changes
Nov 20, 2025
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
LGTM @aryangupta1998 thanks for the patch
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Dec 5, 2025
…tis request size. (apache#9270) (cherry picked from commit 63ee00d) Conflicts: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java Change-Id: If65edcf62195323d437cdb4a5500d82578bc59a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In DirectoryDeletingService, when submitting the request to OM for further processing, we should check if the request exceeds the default rate limit (32 MB). If it does, we should break the request accordingly.
Also, we should process the number of directories to be deleted based on the number specified by the config(ozone.path.deleting.limit.per.task).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13844
How was this patch tested?
Tested Manually(via UT).