HDDS-10298. Replace estimated count with actual count while listing openkeys. #9043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smengcl can you please review the code changes? |
sumitagrawl
reviewed
Sep 23, 2025
...-ozone/cli-admin/src/main/java/org/apache/hadoop/ozone/admin/om/ListOpenFilesSubCommand.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
Outdated
Show resolved
Hide resolved
|
Thanks @sumitagrawl for the review. Addressed your review comments. |
priyeshkaratha
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the estimated count from RocksDB's estimateCount API with an actual count by iterating through the relevant open key tables. The change improves accuracy when listing open files by providing exact counts instead of estimates.
- Replaced estimated count with actual count calculation for open files listing
- Refactored the count method to accept bucket layout and prefix parameters for targeted counting
- Updated CLI output to remove "(est.)" annotation since counts are now accurate
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| OmMetadataManagerImpl.java | Replaced estimated count method with actual iteration-based counting |
| OMMetadataManager.java | Removed the public interface for estimated count method |
| ListOpenFilesSubCommand.java | Updated CLI output formatting to reflect accurate counts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
Show resolved
Hide resolved
smengcl
reviewed
Oct 1, 2025
Comment on lines
+1333
to
+1339
| try (TableIterator<String, String> | ||
| keyValueTableIterator = getOpenKeyTable(bucketLayout).keyIterator(prefix)) { | ||
| while (keyValueTableIterator.hasNext()) { | ||
| count += 1; | ||
| keyValueTableIterator.next(); | ||
| } | ||
| } catch (UncheckedIOException e) { |
There was a problem hiding this comment.
Can we measure how fast it can iterate over 10 million open keys?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As part of this change, the use of the RocksDB estimateCount API for displaying estimated counts has been removed. Instead iterating over either openKeyTable or openFileTable based on the prefix given and calculate the total count.
What is the link to the Apache JIRA
HDDS-10298
How was this patch tested?
Tested locally using command line.