-
Notifications
You must be signed in to change notification settings - Fork 581
HDDS-1228. Chunk Scanner Checkpoints #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@arp7 thanks for the comments on the original PR. I've updated this one to use |
...vice/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerDataScanOrder.java
Show resolved
Hide resolved
arp7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on the comparator, the rest of the patch looks pretty good to me.
HDDS-3188: Fix CI
* Rate limiting * Disabled by default
# This is the 1st commit message: Initial Commit # This is the commit message apache#2: more slight changes # This is the commit message apache#3: changes++ # This is the commit message apache#4: getExecutorService Changes # This is the commit message apache#5: applyTransaction() Changes # This is the commit message apache#6: changes++ # This is the commit message apache#7: TestOzoneManagerLock changes # This is the commit message apache#8: add changes # This is the commit message apache#9: add more minor changes # This is the commit message apache#10: add config to ozone-default.xml # This is the commit message apache#11: minor changes # This is the commit message apache#12: change modulo logic # This is the commit message apache#13: changes # This is the commit message apache#14: changes++ # This is the commit message apache#15: add changes++ # This is the commit message apache#16: minor changes # This is the commit message apache#17: Changes (to be reverted) # This is the commit message apache#18: Changes 09/05
What changes were proposed in this pull request?
Save timestamp of last successful data scan for each container (in the
.containerfile). After a datanode restart, resume data scanning with the container that was least recently scanned.Newly closed containers have no timestamp and are thus scanned first during the next iteration. This will be changed in HDDS-1369, which proposes to scan newly closed containers immediately.
https://issues.apache.org/jira/browse/HDDS-1228
How was this patch tested?
Created and closed containers. Restarted datanode while scanning was in progress. Verified that after the restart, scanner resumed from the container where it was interrupted.
Also tested upgrade from Ozone 0.4.0. (Downgrade does not work, see HDDS-2268.)