-
Notifications
You must be signed in to change notification settings - Fork 587
HDDS-8704. [Snapshot] Add CLI to list SnapDiff jobs #4824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hemantk-12 @smengcl Can you take a look at this PR? |
hemantk-12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch @xBis7.
Left some comments.
...zone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/ListSnapshotDiffHandler.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/ObjectStore.java
Show resolved
Hide resolved
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/protocol/ClientProtocol.java
Show resolved
Hide resolved
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
Outdated
Show resolved
Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/SnapshotDiffJob.java
Show resolved
Hide resolved
...one/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java
Outdated
Show resolved
Hide resolved
...one/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java
Outdated
Show resolved
Hide resolved
...ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestSnapshotDiffManager.java
Outdated
Show resolved
Hide resolved
|
@hemantk-12 I've addressed all your comments. The only ones left are about implementing pagination and renaming I've also added a small test for validating error responses due to invalid volume name or bucket name or snapshot path. |
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Outdated
Show resolved
Hide resolved
...one/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java
Outdated
Show resolved
Hide resolved
...ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestSnapshotDiffManager.java
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmSnapshot.java
Outdated
Show resolved
Hide resolved
Thanks for adding integration test for invalid volume and bucket names. |
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java
Outdated
Show resolved
Hide resolved
|
@hemantk-12 I've addressed all your comments and also merged the branch into master and rewrote the tests to use the new |
...zone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/ListSnapshotDiffHandler.java
Outdated
Show resolved
Hide resolved
...zone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/ListSnapshotDiffHandler.java
Outdated
Show resolved
Hide resolved
|
Hey @smengcl, I've resolved the conflicts and merged the branch into master. |
prashantpogde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @xBis7 .The changes look good to me.
What changes were proposed in this pull request?
This patch adds a new CLI command for listing SnapshotDiff jobs for a bucket based on jobStatus. There is also the option to list all available jobs for the bucket.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8704
How was this patch tested?
This patch was tested with new tests. Also,
snapshot-sh.robotacceptance test was expanded to include listing snapshot diff jobs.