Repository navigation
HDDS-16877. Avoid duplicate initial requests on Recon Containers page - #11484
Open
andyhuangdev wants to merge 3 commits into
Open
andyhuangdev wants to merge 3 commits into
andyhuangdev wants to merge 3 commits into
Conversation
Let auto-reload perform the initial fetch when enabled, and fetch on mount when disabled. Disable the independent clusterState initial fetch. Validation: Checkstyle, RAT, and git diff --check passed.
Contributor
|
@sravani-revuri please review this PR. |
chihsuan
reviewed
Oct 12, 2026
chihsuan
left a comment
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this! @andyhuangdev #11417 added a clusterState workaround for this double fetch in Containers.test.tsx. Could we merge master, drop it, and add a test for the single initial load?
chihsuan
requested review from
ArafatKhan2198 and
spacemonkd
and removed request for
chihsuan
October 12, 2026 10:15
Handle initial loading in useAutoReload when auto refresh is disabled. Remove the Containers mount workaround and clusterState test stub. Add regression coverage for single initial requests, Pipelines loading with auto refresh disabled, and polling lifecycle behavior. Tests: 90 passed, 1 skipped; Recon UI build, checkstyle, and RAT passed.
Contributor
|
Thanks @andyhuangdev for the patch. Please enable the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The Recon v2 Containers page sends duplicate initial requests for MISSING containers, the quasi-closed count, and cluster state. Both the page's initial fetches and the immediate auto-reload poll request the same data, adding unnecessary Recon queries, including the unhealthy containers summary aggregation.
This patch lets the first auto-reload poll perform the initial fetch when auto-reload is enabled. When disabled, a mount effect loads the data through the same refresh function. The independent cluster state initial fetch is disabled.
Manual refresh and periodic polling retain their existing behavior. The change affects data loading only, with no visual changes.
What is the link to the Apache JIRA
[HDDS-16877](https://issues.apache.org/jira/browse/HDDS-16877)
How was this patch tested?
Temporary regression tests reproduced duplicate requests for all three endpoints before the fix and passed afterward. They also covered initial loading with auto-reload disabled, periodic polling, manual refresh, and toggling auto-reload. These tests were removed from the final patch.
The existing Pipelines tests, Checkstyle, RAT, and
git diff --checkpassed.