PHP 7.3 runtime #46
Merged
PHP 7.3 runtime #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runtime uses the Go runtime's ActionProxy as the front end. This speeds things up nicely. However, it also means that the detailed error reporting for invalid data being uploaded to /init is not possible as this is handled by the proxy. As a result, the specific tests that this affects have been moved to the PHP 7.1 and 7.2 test classes. Also, it's not possible to send back specific error messages for output with the action proxy, so the fatal error test no longer checks for the specific error text.
This version has the reliable file detection code which is required to detect zipped PHP files.
We need this for named multi-stage builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP7.3 support for when it releases in early December.
This runtime uses the Go runtime's ActionProxy as the front end. This speeds things up nicely!
However, it also means that the detailed error reporting for invalid
data being uploaded to /init is not possible as this is handled by the
proxy. As a result, the specific tests that this affects have been
moved to the PHP 7.1 and 7.2 test classes.
Also, it's not possible to send back specific error messages for output
with the action proxy, so the fatal error test no longer checks for the
specific error text.