sync knative java with udpates made to openwhisk-runtime-java #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pritidesai
reviewed
Aug 12, 2019
There was a problem hiding this comment.
LGTM, but the build is failing because of missing license header:
[/home/travis/build/apache/openwhisk-devtools/tools/travis/../../.travis.yml]:
1: file does not include required license header.
https://travis-ci.org/apache/openwhisk-devtools/jobs/570893480
pritidesai
previously approved these changes
Aug 13, 2019
|
@pritidesai had not planned on updating all of devtools to be compliant after removal of short header in scancode... but will have to I suppose.... |
pritidesai
approved these changes
Aug 13, 2019
|
@pritidesai tyvm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.