Make it easier to create/update action sequences.#172
Merged
jthomas merged 2 commits intoapache:masterfrom Jun 25, 2019
Merged
Conversation
Adds top-level `sequence` parameter to actions.create/update method. Removes need to manually construct action request body. Fixes apache#168
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 99% 99.03% +0.02%
==========================================
Files 14 14
Lines 402 414 +12
==========================================
+ Hits 398 410 +12
Misses 4 4
Continue to review full report at Codecov.
|
rabbah
approved these changes
Jun 25, 2019
Member
rabbah
left a comment
rabbah
left a comment
There was a problem hiding this comment.
Lgtm modulo the last paragraph and example in the docs which I didn’t understand.
| - `version` - set semantic version of the action. If parameter is empty when create new action openwisk generate 0.0.1 value when update an action increase the patch version. | ||
|
|
||
| If you pass in an array for the first parameter, the `create` call will be executed for each array item. The function returns a Promise which resolves with the results when all operations have finished. | ||
|
|
Member
Author
There was a problem hiding this comment.
If you pass ow.actions.create([{...}, {...}]) it will provide a mechanism for creating multiple actions without having to do the calls manually. This is the doc copied from the section above: https://github.com/apache/incubator-openwhisk-client-js#create--update-action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds top-level
sequenceparameter to actions.create/update method.Removes need to manually construct action request body.
Fixes #168