Skip to content

Fix broken tests around API key changes#420

Merged
dubee merged 3 commits intoapache:masterfrom
dubee:api-key-fixes
Mar 8, 2019
Merged

Fix broken tests around API key changes#420
dubee merged 3 commits intoapache:masterfrom
dubee:api-key-fixes

Conversation

@dubee
Copy link
Member

@dubee dubee commented Mar 8, 2019

Fixing some tests that are broken as a result of API key changes.

Related PR: apache/openwhisk#4284

@dubee dubee added the wip label Mar 8, 2019
Copy link
Member

@rabbah rabbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if some of these tests should be deleted from the cli suite.

assetHelper.withCleaner(wsk.action, name, confirmDelete = false) { (action, _) =>
action.create(name, Some(TestUtils.getTestActionFilename("helloOpenwhiskPackage.js")), kind = Some("nodejs:8"))
action.create(
name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test in particular.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted that one.

@dubee dubee force-pushed the api-key-fixes branch 2 times, most recently from abcb0b1 to 5cb36bb Compare March 8, 2019 19:07
@dubee dubee merged commit ce3c886 into apache:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants