[OPENJPA-2669] Add karaf feature and adapt imports #5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor | ||
| license agreements. See the NOTICE file distributed with this work for additional | ||
| information regarding copyright ownership. The ASF licenses this file to | ||
| you under the Apache License, Version 2.0 (the "License"); you may not use | ||
| this file except in compliance with the License. You may obtain a copy of | ||
| the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required | ||
| by applicable law or agreed to in writing, software distributed under the | ||
| License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS | ||
| OF ANY KIND, either express or implied. See the License for the specific | ||
| language governing permissions and limitations under the License. --> | ||
| <!-- Please keep the project tag on one line to avoid confusing the release | ||
| plugin. --> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
|
|
||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>org.apache.openjpa</groupId> | ||
| <artifactId>openjpa-parent</artifactId> | ||
| <version>3.0.0-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>openjpa-features</artifactId> | ||
| <packaging>pom</packaging> | ||
| <name>OpenJPA Features</name> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.karaf.tooling</groupId> | ||
| <artifactId>karaf-maven-plugin</artifactId> | ||
| <configuration> | ||
| </configuration> | ||
| <executions> | ||
| <execution> | ||
| <id>compile</id> | ||
| <phase>generate-resources</phase> | ||
| <goals> | ||
| <goal>features-generate-descriptor</goal> | ||
| </goals> | ||
| <configuration> | ||
| <addBundlesToPrimaryFeature>false</addBundlesToPrimaryFeature> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.codehaus.mojo</groupId> | ||
| <artifactId>build-helper-maven-plugin</artifactId> | ||
| <executions> | ||
| <execution> | ||
| <id>attach-artifacts</id> | ||
| <phase>package</phase> | ||
| <goals> | ||
| <goal>attach-artifact</goal> | ||
| </goals> | ||
| <configuration> | ||
| <artifacts> | ||
| <artifact> | ||
| <file>target/feature/feature.xml</file> | ||
| <classifier>features</classifier> | ||
| <type>xml</type> | ||
| </artifact> | ||
| </artifacts> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| </project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | ||
| <!-- | ||
|
|
||
| Licensed to the Apache Software Foundation (ASF) under one or more | ||
| contributor license agreements. See the NOTICE file distributed with | ||
| this work for additional information regarding copyright ownership. | ||
| The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| (the "License"); you may not use this file except in compliance with | ||
| the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <features name="openjpa-${project.version}" xmlns="http://karaf.apache.org/xmlns/features/v1.3.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://karaf.apache.org/xmlns/features/v1.3.0 http://karaf.apache.org/xmlns/features/v1.3.0"> | ||
|
|
||
| <feature name="openjpa" description="Apache OpenJPA 3 persistence engine support" version="${project.version}"> | ||
| <details>Apache OpenJPA persistence engine</details> | ||
| <feature>jndi</feature> | ||
| <bundle dependency="true">mvn:org.apache.geronimo.specs/geronimo-jta_1.1_spec/1.1.1</bundle> | ||
| <bundle dependency="true">mvn:org.eclipse.persistence/javax.persistence/2.1.0</bundle> | ||
| <bundle dependency="true">mvn:org.apache.geronimo.specs/geronimo-annotation_1.0_spec/1.1.1</bundle> | ||
| <bundle dependency="true">mvn:org.apache.geronimo.specs/geronimo-el_1.0_spec/1.0.1</bundle> | ||
| <bundle dependency="true">mvn:commons-pool/commons-pool/1.6</bundle> | ||
|
There was a problem hiding this comment. we should likely move to dbcp2 today no? There was a problem hiding this comment. Makes sense .. or not use require any pooling at all. I let pax-jdbc-config create a pooled DataSource There was a problem hiding this comment. +1 to not handle it there |
||
| <bundle dependency="true">mvn:commons-dbcp/commons-dbcp/1.4</bundle> | ||
| <bundle dependency="true">mvn:commons-collections/commons-collections/3.2.2</bundle> | ||
| <bundle dependency="true">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.serp/1.14.1_1</bundle> | ||
| <bundle dependency="true">mvn:org.apache.xbean/xbean-asm5-shaded/4.3</bundle> | ||
| <bundle>mvn:org.apache.openjpa/openjpa/${project.version}</bundle> | ||
| </feature> | ||
|
|
||
| </features> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not geronimo? http://repo.maven.apache.org/maven2/org/apache/geronimo/specs/geronimo-jpa_2.1_spec/1.0-alpha-1/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well alpha-1 does not sound so trustworthy :-) I just checked that you created the bundle. Is it stable ? If yes it would be great if you could release a 1.0.0 version so people know it is safe to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alpha-1 for EE 7 spec was cause of this TCK thing only, I didn't check the OSGi part but that would be easy to enhance and stay consistent with karaf ecosystem I think.