feat(services/opfs): add delete/stat support for OPFS #6564
Conversation
dosubot
bot
added
size:XXL
.github/workflows/test_behavior.yml
Outdated
| os: ${{ matrix.os }} | ||
| cases: ${{ toJson(matrix.cases) }} | ||
|
|
||
| test_opfs: |
There was a problem hiding this comment.
Hi, opfs is a new service, and I didn’t expect it to be added as a new type for behavior tests.
There was a problem hiding this comment.
I'm not sure if we need to duplicate all the tests for WASM again.
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| name: OPFS Test |
There was a problem hiding this comment.
We can add opfs test as a new edge case under at https://github.com/apache/opendal/blob/main/.github/workflows/test_edge.yml
core/src/services/opfs/reader.rs
Outdated
|
|
||
| let (tx, rx) = mpsc::unbounded(); | ||
|
|
||
| // everything in wasm-bindgen is non-send, so we need to spawn a new task |
There was a problem hiding this comment.
oio::Read and oio::List should be able to implemented in a non-Send way. I think we can avoid the those usage of channel. What's the problem we are facing now?
There was a problem hiding this comment.
Since everything is non-Send and non-Sync under wasm, but Read requires Send + Sync, I can't hold any content related to wasm in OpfsReader.
There was a problem hiding this comment.
I think we can remove read/write/list from this PR for now and open a new issue on how to implememt these without using channel. What do you think @Xuanwo ?
There was a problem hiding this comment.
I think we can remove read/write/list from this PR for now and open a new issue on how to implememt these without using channel. What do you think @Xuanwo ?
Sorry for the late. And this plan looks good to me
dosubot
bot
added
size:XL
crwen
force-pushed
the
feat/opfs
branch
3 times, most recently
from
8cfafd8 to
490d9a5
Compare
crwen
changed the title
dosubot
bot
added
size:L
# Conflicts: # core/core/Cargo.toml # core/core/src/services/mod.rs # core/services/etcd/src/error.rs # core/services/opfs/src/backend.rs # core/services/opfs/src/builder.rs # core/services/opfs/src/core.rs # core/services/opfs/src/delete.rs # core/services/opfs/src/lib.rs # core/services/opfs/src/utils.rs
3 participants
Which issue does this PR close?
Related to #5799.
Rationale for this change
What changes are included in this PR?
core/edge/opfs_on_wasm). These tests are basically copied fromcore/tests/behaviorNotice:
Are there any user-facing changes?