fix(binding/java): Overwrite default NOTICE file with correct years#2918
fix(binding/java): Overwrite default NOTICE file with correct years#2918Xuanwo merged 2 commits intoapache:mainfrom
Conversation
Signed-off-by: tison <wander4096@gmail.com>
|
This is indeed a reasonable way to make sure the NOTICE contains correct years. For example, commons-collections does something similar. An alternative approach is to make sure The latter approach still has the timezone problem mentioned earlier - though it is much less likely to be encountered for 'realistic' dates. apache/maven-remote-resources-plugin#39 should fix it. |
|
@raboof Thanks for your information! I added this NOTICE file following Flink's practice. Correct years is one of the target, the other one is properly mentioning dependencies' NOTICE/LICENSE if any, although opendal-java doesn't have one now. |
|
But the timezone problem seems need to resolve as for "project.build.outputTimestamp". Do you have some idea here or may you directly send a patch against this repo to fix it? |
👍 great!
I don't think there is any timezone issue anymore now that you've replaced the NOTICE. The code in https://github.com/apache/maven-remote-resources-plugin that introduced that problem is not used in the opendal binding project anymore. |
This closes #2916.
Verified locally. And yes, opendal-java contains built without any compile dependency on Maven Central.
FYI @markt-asf this should address the issue you spot :D