feat(azure): implement client secret auth for azure#457
Merged
Xuanwo merged 1 commit intoapache:mainfrom Aug 6, 2024
Merged
Conversation
1 task
twuebi
force-pushed
the
tp/azdls-client-secr
branch
from
62198e7 to
c1aee8b
Compare
twuebi
force-pushed
the
tp/azdls-client-secr
branch
from
c1aee8b to
ba8edc9
Compare
Member
|
Thanks a lot for your PR! I will review and try to test this PR later this week. |
Contributor
Author
|
Thanks! I think we're mostly missing CI + secrets to have the test also run via GitHub actions. Locally, I've tested it against azure. The second aspect I'm not 100% settled on is to combine some logic between the imds and client secret paths, they are quite similar. |
Xuanwo
approved these changes
Aug 6, 2024
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Sorry for the late, and thaks for a lot for build this PR!
TennyZhuang
pushed a commit
to TennyZhuang/reqsign
that referenced
this pull request
Nov 4, 2024
Xuanwo
pushed a commit
that referenced
this pull request
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.