Skip to content

Comments

OFBIZ-11756 vue js renderer#27

Closed
Olivier-Heintz wants to merge 21 commits intoapache:trunkfrom
Olivier-Heintz:OFBIZ-11756_VueJs-renderer
Closed

OFBIZ-11756 vue js renderer#27
Olivier-Heintz wants to merge 21 commits intoapache:trunkfrom
Olivier-Heintz:OFBIZ-11756_VueJs-renderer

Conversation

@Olivier-Heintz
Copy link

Implemented: add plugins to have ofbiz components usable with the vuejs renderer (OFBIZ-11756)

Explanation
3-4 new addons: vuejs, themefrontjs, examplefjs and partyfjs to be able to have a complete usage of vuejs renderer (included in vuejs plugin)

Thanks: to Julien Bachelier for Vue.Js code in vuejs plugin

@JacquesLeRoux
Copy link
Contributor

Hi Olivier,

SonarCloud Code Analysis was not good :/ Could you please check?

After that I'll check all "SonarCloud Quality Gate failed." messages to "apache/ofbiz-*ofbiz-*@noreply.github.com" they went unnoticed so far

@JacquesLeRoux
Copy link
Contributor

Hi Olivier,

It seems uneasy but please check the issues reported by "SonarCloud Quality Gate ", TIA

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2020

SonarCloud Quality Gate failed.

Bug C 10 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 7 Security Hotspots to review)
Code Smell A 216 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@Olivier-Heintz Olivier-Heintz force-pushed the OFBIZ-11756_VueJs-renderer branch from d007a3a to 542d70b Compare August 3, 2020 15:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 5, 2020

SonarCloud Quality Gate failed.

Bug C 11 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 7 Security Hotspots to review)
Code Smell A 216 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@Olivier-Heintz Olivier-Heintz force-pushed the OFBIZ-11756_VueJs-renderer branch from 1ab7731 to 7dca015 Compare October 2, 2020 14:18
@Olivier-Heintz Olivier-Heintz force-pushed the OFBIZ-11756_VueJs-renderer branch from 7dca015 to 00dcd83 Compare October 23, 2020 17:23
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 216 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug C 8 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 216 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

holivier and others added 20 commits February 12, 2021 15:26
plugin

rename all flatgrey to fronjs or thfrontjs
Previous one has symbolic link not files
and correction for mini stylesheet which was with a old theme name
(OFBIZ-11907) (#221)

after modification in trunk: WidgetWorker now build URI and URL is build
after call to WidgetWorker.
send directly target and targetType

Currently, buildHyperlinkUri not supports uri with parameters write with
{xxxx}
should be study to know if it's a bug or parameters like this should not
appear.

in vuejs targetType is not yet manage, there will be some error/warning
message added when code review will be done on this method
…reenBegin by renderBegin and same for close.
@Olivier-Heintz Olivier-Heintz force-pushed the OFBIZ-11756_VueJs-renderer branch from 1b9a6fb to 992ee19 Compare February 12, 2021 14:27
@mbrohl
Copy link
Contributor

mbrohl commented Feb 12, 2021

@Olivier-Heintz This PR seems to be problematic in several aspects:

  • there is too much code duplication, see sonarcloud analysis. Please try to avoid copied inline functions and write them in separate function to reuse them
  • the commits do not follow the commit message template (Fixed:, Improved: etc.)

@mbrohl
Copy link
Contributor

mbrohl commented Feb 12, 2021

If you want to show that this is a draft PR which is not finished yet to be reviewed and merged, you can also specify a "draft pull request". I did not find a way to specify this afterwards so you might need to provide a new PR instead.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 220 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@Olivier-Heintz
Copy link
Author

Thank you Michael for your remarks.
This PR is to show what is working but clearly, not yet ready to be merge.
I will try to create a "draft pull request".

PS: Currently, my knowledge of vuejs is not enough to remove all duplicate lines !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants