Improved: Made wording in ScurityUiLabels.xml for key loginevents.following_error_occurred_during_login consistent across supported languages (OFBIZ-13340) #937
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loginevents.following_error_occurred_during_login consistent across
supported languages (OFBIZ-13340)
* The UI label loginevents.following_error_occurred_during_login in
* framework/common/config/SecurityextUiLabels.xml{} is inconsistently
* translated across locales.
* Some languages only display ${errorMessage} without context, while
* others include a full sentence (e.g. “following error occurred during
* login”).
* This leads to ambiguous and inconsistent user-facing error messages.
* Using only ${errorMessage} for all locales ensures consistency across
* languages, avoids redundant or awkward translations, and prevents
* grammatical issues when error messages are dynamically generated.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI label loginevents.following_error_occurred_during_login in framework/common/config/SecurityextUiLabels.xml{} is inconsistently translated across locales.
Some languages only display ${errorMessage} without context, while others include a full sentence (e.g. “following error occurred during login”).
This leads to ambiguous and inconsistent user-facing error messages. Using only ${errorMessage} for all locales ensures consistency across languages, avoids redundant or awkward translations, and prevents grammatical issues when error messages are dynamically generated.