Improved: Sanitize all widget xml ressource location - #1552
Open
nmalin wants to merge 1 commit into
Open
Conversation
When you load dynamically an XML file to a widget model you need to follow the security rule * location from component (component://) without other url or '..' * if not a component, the string path is present on an allowed path in security.properties : allowFilePaths
ashishvijaywargiya
added a commit
that referenced
this pull request
Aug 14, 2026
…owlist (#1650) Add WidgetSecureLocation as a single gatekeeper for screen, form, grid, menu, and tree resource locations. Reject any file: scheme location regardless of letter case, reject '..' traversal inside component:// locations, and deny non-component locations by default unless allowed via the new security.allowFilePaths pattern. Also stop anonymous JSON request bodies from overriding request attributes that already exist as trusted ServletContext attributes, which is how a request-controlled value could shadow a webapp's configured decorator location. Adds unit tests for the new checks. Thank you Krishna Uprit(@Krishnauprit18) and Nicolas Malin(@nmalin) for your help. PR from @nmalin - #1552 PR from @Krishnauprit18 - #1586
ashishvijaywargiya
added a commit
to ashishvijaywargiya/ofbiz-framework
that referenced
this pull request
Aug 14, 2026
…owlist (apache#1650) Add WidgetSecureLocation as a single gatekeeper for screen, form, grid, menu, and tree resource locations. Reject any file: scheme location regardless of letter case, reject '..' traversal inside component:// locations, and deny non-component locations by default unless allowed via the new security.allowFilePaths pattern. Also stop anonymous JSON request bodies from overriding request attributes that already exist as trusted ServletContext attributes, which is how a request-controlled value could shadow a webapp's configured decorator location. Thank you Krishna Uprit(@Krishnauprit18) and Nicolas Malin(@nmalin) for your help. PR from @nmalin - apache#1552 PR from @Krishnauprit18 - apache#1586 (cherry picked from commit 4afb9c9)
ashishvijaywargiya
added a commit
to ashishvijaywargiya/ofbiz-framework
that referenced
this pull request
Aug 14, 2026
…owlist (apache#1650) Add WidgetSecureLocation as a single gatekeeper for screen, form, grid, menu, and tree resource locations. Reject any file: scheme location regardless of letter case, reject '..' traversal inside component:// locations, and deny non-component locations by default unless allowed via the new security.allowFilePaths pattern. Also stop anonymous JSON request bodies from overriding request attributes that already exist as trusted ServletContext attributes, which is how a request-controlled value could shadow a webapp's configured decorator location. Thank you Krishna Uprit(@Krishnauprit18) and Nicolas Malin(@nmalin) for your help. PR from @nmalin - apache#1552 PR from @Krishnauprit18 - apache#1586 (cherry picked from commit 4afb9c9)
ashishvijaywargiya
added a commit
to ashishvijaywargiya/ofbiz-framework
that referenced
this pull request
Aug 14, 2026
…owlist (apache#1650) Add WidgetSecureLocation as a single gatekeeper for screen, form, grid, menu, and tree resource locations. Reject any file: scheme location regardless of letter case, reject '..' traversal inside component:// locations, and deny non-component locations by default unless allowed via the new security.allowFilePaths pattern. Also stop anonymous JSON request bodies from overriding request attributes that already exist as trusted ServletContext attributes, which is how a request-controlled value could shadow a webapp's configured decorator location. Thank you Krishna Uprit(@Krishnauprit18) and Nicolas Malin(@nmalin) for your help. PR from @nmalin - apache#1552 PR from @Krishnauprit18 - apache#1586 (cherry picked from commit 4afb9c9)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you load dynamically an XML file to a widget model you need to follow the security rule