cache alien element and attribute class to make it faster in OdfXMLFactory

[ravenq]

Hi,

Class.forName may not be an efficient method. and in org.odftoolkit.odfdom.pkg.OdfXMLFactory line:153 Class, it use Class.forName to find the Element/Atrribute Class. The classCache map make it better to find the Class. But we need a cache for Alien Element/Atrribute Class too, otherwise it will find the same alien Class by Class.forName again and again. It take too much of CPU cycle.

Related JIRA:https://issues.apache.org/jira/projects/ODFTOOLKIT/issues/ODFTOOLKIT-473

Regards.

ravenq.

[svanteschubert]

Within the OdfXMLFactory the new inserted HashSet mAlienTypes is never filled, the new condition will never be met. Is there something missing?

Similar the test file will just give out the loading time and not test anything as the test will never fail.

We might need some performance tests, but I am not sure how to provide them using some existing open-source 3rd party perf-test tool..

[ravenq]

Thanks for @svanteschubert !

The mAlienTypes will be filled when catch ClassNotFoundException/NoClassDefFoundError Exceptions.

There is much Alien Element and Attribute Node in the testAlienPerformance.odt. And the alien node always create by 3rd applications. In my work, it have a lot of odt file like this.It take too much time to load a odt file.

And for the performance test, I just want to show this problem. It is not a good test case for preformance test. so I will remove it if necessary.

Regards.

ravenq.

[svanteschubert]

Mea Culpa, I misread the patch.
First time reviewing a patch via GitHub, but now I realized it is easy to access the patch by adding the ".patch" suffix the URL:
https://github.com/apache/odftoolkit/pull/3.patch

The mAlienTypes were once commented and you enabled them. I will have to think about it tomorrow, why somebody disabled this, when I have again a coffee in my hand.. ;-)

I am building your patch now and will likely look deeper into it tomorrow.

[ravenq]

Thanks for @svanteschubert

There is nobody disabled it. I push 3 commits in this PR. and I disable it carelessly in my commit 2.
And I do not know how to squash it in GitHub.

Regards.
ravenq.