Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hdc1008 sensor driver #975

Merged
merged 3 commits into from
May 5, 2020
Merged

Hdc1008 sensor driver #975

merged 3 commits into from
May 5, 2020

Conversation

iceaway
Copy link
Contributor

@iceaway iceaway commented May 5, 2020

Summary

New driver for the HDC1008 temperature/humidity sensor. Not sure about the copyright notice in the file header after the apache move, please let me know if I should change it.

Impact

Testing

Tested on a stm32f103 (bluepill) board. Example application in a separate pull request to the apps repo.

@iceaway iceaway mentioned this pull request May 5, 2020
* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*
****************************************************************************/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but as an Apache project, all new files must have the Apache 2.0 header. Could you please copy/paste the header from, sched/sched/sched_getcpu.c? No copyrights or authors in the the Apache header.

* ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
* POSSIBILITY OF SUCH DAMAGE.
*
****************************************************************************/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but as an Apache project, all new files must have the Apache 2.0 header. Could you please copy/paste the header from, sched/sched/sched_getcpu.c? No copyrights or authors in the the Apache header.

Copy link
Contributor

@patacongo patacongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All new files added to NuttX must have the Apache 2.0 license / file header.

@iceaway
Copy link
Contributor Author

iceaway commented May 5, 2020

Both files have been updated with the apache 2.0 header, please check again if it looks ok.

@patacongo
Copy link
Contributor

Both files have been updated with the apache 2.0 header, please check again if it looks ok.

Thank! I will merge when the checks compelte.

@patacongo
Copy link
Contributor

I don't think we need to wait for all of the PR checks. They all passed last time.

@patacongo patacongo merged commit b525218 into apache:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants